Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize live games when there is a multi header #256

Merged
merged 5 commits into from Apr 17, 2019

Conversation

@Nixon506E
Copy link
Contributor

Nixon506E commented Mar 27, 2019

#88 Check for multiple games for a team in a given day and then do is_live check when getting current index for a team

Nixon506E added 5 commits Mar 15, 2019
Make team filter more pythonic by using for if (was not properly finding games using lambda filter)
Check for offday with pythonic for if instead of enumerate
Bug Fix
Use global games variable on self
Check for multiple games for a team in a given day and then do is_live check if so
@swemoney

This comment has been minimized.

Copy link
Collaborator

swemoney commented Mar 28, 2019

I really want to do a lot more with detecting live games and doing things differently depending on games that are live but the reason I've always decided not to (yet) is needing to fetch the overview from MLB every time we want to see if the game is live. Some work is being done on moving mlbgame over to the newer json based API which, I believe, we'll have an up to date status for all games in a single update. So this feature (as well as things like #51) have been kind of on the back burner because of it.

I still want to test this out, though, when I have a free moment.

@ajbowler

This comment has been minimized.

Copy link
Collaborator

ajbowler commented Apr 13, 2019

@swemoney are you still messing with this? This looks good to me as is.

@ajbowler

This comment has been minimized.

Copy link
Collaborator

ajbowler commented Apr 17, 2019

@swemoney @Nixon506E I am going to merge this into dev. I'm not noticing any slow behavior with the overview refreshes.

@ajbowler ajbowler merged commit b1fcbc6 into MLB-LED-Scoreboard:dev Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.